Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate who is responsible for generating example documents #90

Open
jeswr opened this issue Jan 4, 2025 · 3 comments
Open

Indicate who is responsible for generating example documents #90

jeswr opened this issue Jan 4, 2025 · 3 comments
Assignees
Labels
CR2 This item was processed during the second Candidate Recommendation Phase editorial The item is editorial in nature. ready for pr This issue is ready for a Pull Request to be created to resolve it

Comments

@jeswr
Copy link
Member

jeswr commented Jan 4, 2025

To improve readability, it would be useful to have:

  • For each example scenario have a table indicating who the entities of interest are; e.g. for the windsurfing example: surfer = holder, race organiser = verifier, equipment manufacturer(s) = issuer.
  • Who (holder, issuer, verifier) is responsible for generating the document displayed in the example, and who, if anyone it is sent to - e.g. in example 113 I my understanding is that the Mandatory Pointers are created by the race organiser / verifier and sent to the surfer / holder who then generates example 114; but I am not confident of this understanding.
@msporny msporny added editorial The item is editorial in nature. CR2 This item was processed during the second Candidate Recommendation Phase ready for pr This issue is ready for a Pull Request to be created to resolve it labels Jan 14, 2025
@Wind4Greg
Copy link
Collaborator

Hi @jeswr this example has been flagged in another issue (#86) as problematic. I've proposed that we drop the example as the simplest solution as we already have two other ECDSA-SD examples. Let me know if this resolves this issue for you.

@jeswr
Copy link
Member Author

jeswr commented Jan 21, 2025

The key ask here is to label who (holder, issuer, verifier) is responsible for generating the document displayed in every example.

Example 113 is one of the places this is most useful, but not the only one. So removing example 113 does not resolve the issue.

@Wind4Greg
Copy link
Collaborator

Hmm, maybe this is a bigger picture issue rather than an example/test vector issue.

In the non-selective disclosure case:

  1. Issuer uses appropriate Create Proof procedure
  2. Verifier uses appropriate Verify Proof procedure

Test vectors do not go through the verification procedure so verifier is not involved.

In the selective disclosure case:

  1. Issuer uses Create Base Proof
  2. Holder uses Add Derived Proof
  3. Verifier uses Verify Derived Proof

Test vectors do not go through the verification procedure so verifier is not involved.

Do you just want this change on Appendix A? Can you give specific wording?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR2 This item was processed during the second Candidate Recommendation Phase editorial The item is editorial in nature. ready for pr This issue is ready for a Pull Request to be created to resolve it
Projects
None yet
Development

No branches or pull requests

3 participants