Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause/resume are not very well defined #191

Open
youennf opened this issue Jan 26, 2020 · 2 comments
Open

pause/resume are not very well defined #191

youennf opened this issue Jan 26, 2020 · 2 comments

Comments

@youennf
Copy link
Contributor

youennf commented Jan 26, 2020

The description of pause and resume is not very clear to me. The spec says that:

  • Stop gathering data into blob (but keep it available so that recording can be resumed in the future).

This could be either understood as:

  • continue encoding but do not add data to that blob (but added back to the blob on resume or added to the next blob once requestData is created)
  • pause encoding so no new encoded data is generated at all (but keep any already encoded data). Encoding will be restarted once resume is called, which probably needs proper handling of timestamps.

WPT tests seem to be lacking in that area as well.

@jesup
Copy link

jesup commented Jan 26, 2020

The intention was the second: pause encoding, with the possibility of resuming it (with any new source data between 'pause' and 'resume' ignored). If you specifically define 'it' in "but keep it available" to be "the blob", it becomes more clear. (in formal english 'it' would refer to 'blob', but I can see how it can be confusing)

@sunggook
Copy link

Do we have list of cases when 'pause' and 'resume' events will be fired? for example, track ended for any reason (e.g. OS sleep).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants