Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to execute 'insertBefore' on 'Node': parameter 1 is not of type 'Node'. #12650

Open
mingpepe opened this issue Jan 6, 2025 · 2 comments · May be fixed by #10748
Open

Failed to execute 'insertBefore' on 'Node': parameter 1 is not of type 'Node'. #12650

mingpepe opened this issue Jan 6, 2025 · 2 comments · May be fixed by #10748
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has workaround A workaround has been found to avoid the problem

Comments

@mingpepe
Copy link

mingpepe commented Jan 6, 2025 •
edited
Loading

Vue version

3.5.13

Link to minimal reproduction

https://play.vuejs.org/#__PROD__eNqlU02P0zAQ/SvGl92VNolQ4RKyEQnaAyABKhwtoTSZdL3rOpY/QlHV/87YbrMplB7gFs978/Jm/LyjlVLp6IDmtDCt5soSA9apkkm+UYO2ZEfMQyPE8GMJPdmTXg8bcoUdVxOjOhTTrPJSz0A9AfUBYLIdpLGkdVqDtORuJn5d3bxhssiiDTSABwsbJRoLeCKkEM0KRFlwqZwl9qeCO0Z10/GBUTImm6EDgZWDNtbysRHOkyo8ZCWpiixK/J9aHdXqE7WPAKoSfIxWsdAOuATph8y5mQuVRTZhsTebNxfZbGh6S63BlfV8nT6aQeI17XwLyqEEF6A/K8txpYzmJCAeCxv9EGpWO7g91tsHaJ/O1B/N1tcY/aLBgB6B0QmzjV4Duvbw/ddPsMXvCcQlOYHsC+ASzCCc9xhptZMd2p7xgtv3ITFcrr+Z+60FaY5DeaOeuQ98RjFH7y6M/mx3kb4KfUzucYshmf8U8hhY7aREd6eB7RthwIe2d7L1Xjzt+ubo5tCThtxgpx8FyeegoIQYur30AFbOWvzL21bw9snH1eFWy6XDpghF2oskIUkSv0/iHQKwGvC2Sd5x06wEdFHGu2E0O5O/8HT/2NxfXf7e/n0E7S8TFRbp6/Tlgu5/ATTPgKw=

Steps to reproduce

Press button 'Run' and switch to tab 'B'

What is expected?

No error

What is actually happening?

With testing, following conditions are necessary to trigger this issue.

  1. KeepAlive
  2. Comment in A.vue
  3. Function Run ever changed reference running
  4. An element use reference running

This only occurs in production build.

System Info

No response

Any additional comments?

My real project use electron + typescript + vue.
When it compiles to package, not every build will result in this issue.
But it can always reproduce in vue playground.
@linzhe141
Copy link
Contributor

It is similar to this #10747

@edison1105 edison1105 linked a pull request Jan 6, 2025 that will close this issue
Open
@edison1105 edison1105 added has workaround A workaround has been found to avoid the problem 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Jan 6, 2025
@edison1105
Copy link
Member

Removing the comment is a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has workaround A workaround has been found to avoid the problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-core): inherit comment nodes during block patch in production build tonliver/core
3 participants
@edison1105 @mingpepe @linzhe141