Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compile-sfc): support resolve type from .jsx file #12649

Closed
wants to merge 2 commits into from

Conversation

zhennann
Copy link

@zhennann zhennann commented Jan 6, 2025

enhance: support .jsx

@zhennann zhennann changed the title enhance: support .jsx enhance(compile-sfc): support .jsx Jan 6, 2025
@edison1105
Copy link
Member

Could you please add a test case for this PR?

@edison1105 edison1105 changed the title enhance(compile-sfc): support .jsx fix(compile-sfc): support resolve type form .jsx file Jan 6, 2025
@edison1105 edison1105 added the need test The PR has missing test cases. label Jan 6, 2025
@zhennann
Copy link
Author

zhennann commented Jan 6, 2025

Could you please add a test case for this PR?

Test case has been added.

@zhennann zhennann changed the title fix(compile-sfc): support resolve type form .jsx file fix(compile-sfc): support resolve type from .jsx file Jan 6, 2025
@edison1105 edison1105 removed need test The PR has missing test cases. scope: sfc labels Jan 6, 2025
@edison1105
Copy link
Member

em... Please note this line

// #8339 ts may import .js but we should resolve to corresponding ts or d.ts

I don't think .jsx has the same problem.

@edison1105 edison1105 closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants