fix(runtime-core): inherit comment nodes during block patch in production build

[tonliver]

close #10747
close #12650

[netlify]

❌ Deploy Preview for vue-sfc-playground failed.

Name	Link
🔨 Latest commit	46f6f3b
🔍 Latest deploy log	https://app.netlify.com/sites/vue-sfc-playground/deploys/66231674bd858b000859c462

[netlify]

❌ Deploy Preview for vue-next-template-explorer failed.

Name	Link
🔨 Latest commit	46f6f3b
🔍 Latest deploy log	https://app.netlify.com/sites/vue-next-template-explorer/deploys/662316740aee4500083b5a0e

[tonliver]

@edison1105 I think assuming that all comments should be removed in production mode, then there shouldn't create vnodes for comments in production mode for performance reason. However, comment vnodes are created, also removed by nodeOpt.remove method during unmounting, except for traversStaticChildren, which lacks consistency. Indeed this inconsistency in handling caused the exception.

[edison1105]

@tonliver Could you add a test case?

[tonliver]

@tonliver Could you add a test case?

Sure, I'll work on it as soon as possible.

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	100 kB (+31 B)	37.9 kB (+9 B)	34.2 kB (+20 B)
vue.global.prod.js	158 kB (+31 B)	57.8 kB (+10 B)	51.5 kB (+67 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.3 kB (+31 B)	18.2 kB (+12 B)	16.6 kB (+11 B)
createApp	54.3 kB (+31 B)	21.1 kB (+10 B)	19.3 kB (-1 B)
createSSRApp	58.5 kB (+31 B)	22.9 kB (+11 B)	20.8 kB (+6 B)
defineCustomElement	59.1 kB (+31 B)	22.7 kB (+15 B)	20.7 kB (-4 B)
overall	68.3 kB (+31 B)	26.3 kB (+8 B)	24 kB (+67 B)

[tonliver]

@edison1105 I've added some test cases.

[tonliver]

@edison1105 What else can I do?

[tonliver]

@yyx990803 What else can I do?

[pkg-pr-new]

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@10748

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@10748

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@10748

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@10748

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@10748

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@10748

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@10748

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@10748

@vue/shared

npm i https://pkg.pr.new/@vue/shared@10748

vue

npm i https://pkg.pr.new/vue@10748

@vue/compat

npm i https://pkg.pr.new/@vue/compat@10748

commit: af25c8c