Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of tar files #279

Open
jg-development opened this issue Sep 16, 2024 · 2 comments
Open

Support of tar files #279

jg-development opened this issue Sep 16, 2024 · 2 comments

Comments

@jg-development
Copy link

Some providers use tar file for download.
=> mirasvit

This results in zipball errors.
Maybe add a tarball controller or convert to zip?

{
    "packages": {
        "mirasvit/module-core": {
            "1.2.0": {
                "name": "mirasvit/module-core",
                "version": "1.2.0",
                "version_normalized": "1.2.0.0",
                "dist": {
                    "type": "tar",
                    "url": "https://packages.mirasvit.com/XXXXX:XXXXXX/downloads/mirasvit-module-core-1.2.0-f9bcd4.tar",
                    "reference": "45e828042a2c197e86f9b649098bdefa12a20d48"
                },
                "require": {
                    "magento/framework": "100.0.*",
                    "magento/module-backend": "100.0.*",
                    "magento/module-store": "100.0.*",
                    "php": "~5.5.0|~5.6.0|~7.0.0"
                },
                "time": "2016-02-11 15:19:45",
                "type": "magento2-module",
                "autoload": {
                    "files": [
                        "src/Core/registration.php"
                    ],
                    "psr-4": {
                        "Mirasvit\\Core\\": "src/Core"
                    }
                },
                "license": [
                    "proprietary"
                ],
                "description": "Mirasvit Core"
            }
        }
    }
}
@vtsykun
Copy link
Owner

vtsykun commented Sep 16, 2024

Hi @jg-development

Can you describe step to reproduce? I mean, where did you get this JSON payload and how is it used by Packeton

{
    "packages": {
        "mirasvit/module-core": {
            "1.2.0": {
                "name": "mirasvit/module-core",
                "version": "1.2.0",
                "version_normalized": "1.2.0.0",
                "dist": {
                    "type": "tar",
                    "url": "https://packages.mirasvit.com/XXXXX:XXXXXX/downloads/mirasvit-module-core-1.2.0-f9bcd4.tar",
                    "reference": "45e828042a2c197e86f9b649098bdefa12a20d48"
                },

@jg-development
Copy link
Author

Hi @vtsykun
this is from a magento2 extension provider. I was using it with the proxy feature, but I am pretty sure it can be used with a normal "submit" feature (example gitlab), too.
The zipball controller is always using zip for content-type output and "somewhere" the dist content is downloaded in the packeton/dismanager. Am I wrong here and packeton is repacking everything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants