Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up role checks #47

Open
vphantom opened this issue Feb 25, 2017 · 0 comments
Open

Clean up role checks #47

vphantom opened this issue Feb 25, 2017 · 0 comments

Comments

@vphantom
Copy link
Owner

vphantom commented Feb 25, 2017

Right now, because some things can be done by administrators, editors-in-chief and editors, I used various indirect ways of checking, such as can('delete', 'article'). Maybe instead, administrators should have the two other roles tagged on, and editors-in-chief should have editor tagged on. They would then be inclusive.

Another option might be to describe inclusion in config.ini although that would mean having to refactor the ACL loader to process those recursively.

Once that's done, all code and templates should be scanned and updated to actually use proper has_role() checks where appropriate.

We also have the problem that editors which are also peers lose sight of any articles they can't review, so we need to audit all permissions checks to make sure they're positive, not negative like this peer check.

@vphantom vphantom added this to the v1.2.0 Usability Improvements milestone Feb 25, 2017
@vphantom vphantom self-assigned this Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant