Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One base manifest, many operator files #4

Open
drnic opened this issue Apr 24, 2018 · 2 comments
Open

One base manifest, many operator files #4

drnic opened this issue Apr 24, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@drnic
Copy link

drnic commented Apr 24, 2018

I appreciate that you've shown many different ways to run Harbor with different manifests. I'm writing to share a pattern that is evolving in other BOSH releases.

In the BOSH community, the consistent pattern we're going with is:

  • A manifests folder (some older projects have a templates folder, but manifests is newer and nicer)
  • A manifests/operators folder (some projects have manifests/ops-files)
  • A manifests/harbor.yml base manifests that works with zero user-provided variables, e.g. no static IPs or elastic IPs, contains releases: that reference final releases or ideally compiled releases, and allows the very simple README instructions:
    bosh -d harbor deploy manifests/harbor.yml
    
  • manifests/operators/create.yml - overrides the harbor release with version: create and uri: . to make it easy to run bosh deploy manifests/harbor.yml -o manifests/operators/create.yml to emulate bosh create-release --force && bosh upload-release --rebase && bosh deploy ...
  • various other operator files to reproduce your existing manifest examples; some of these might be vsphere.yml etc where you're trying to communicate something specific about the target infrastructure; but this isn't common. In your manifests, the only "vsphere" idea I see is the static IP, rather than an elastic IP for other infrastructures?

An example BOSH release project that maintains this pattern is https://github.com/cloudfoundry-community/redis-boshrelease

Thanks for open sourcing the Harbor bosh release!

/cc @cppforlife

@jessehu
Copy link
Contributor

jessehu commented Apr 24, 2018

Thanks a lot @drnic. Your suggestions are really helpful. We will find time to make according improvement. We also welcome any kind of contribution to harbor-boshrelease project.

@jessehu
Copy link
Contributor

jessehu commented May 17, 2018

Hi @drnic, I have cleaned up the manifest files in commit 089c7c5. Will use the operators approach when adding more deployment manifests.

@jessehu jessehu added the enhancement New feature or request label May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants