Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running build_registry.go multiple times, we hit resource not modified http error 304 #98

Open
srikartati opened this issue Dec 3, 2020 · 1 comment
Labels
bug Something isn't working high-priority Needs to be taken care with high priority

Comments

@srikartati
Copy link
Contributor

Describe the bug
With code generation check worflow, we run build_registry.go multiple times in quick succession. During its run, we do http.get on https://www.iana.org/assignments/ipfix/ipfix-information-elements.csv. There is cache control introduced on this link/resource, so we hit the error 304. Because of this error, we generate empty pkg/registry/registry_IANA.go file.
In addition, because of this code generation check workflow fails on PRs.

To Reproduce
Run the following commands multiple times in quick succession:
go run pkg/registry/build_registry/build_registry.go

Expected behavior
Even with multiple runs of build_registry.go, we should see proper generation of the file, pkg/registry/registry_IANA.go with all the info elements in it.

Actual Behavior
Because of this HTTP error, we generate empty go file.

Versions
master branch ToT.

Additional context
Add any other context about the problem here.

@srikartati srikartati added bug Something isn't working high-priority Needs to be taken care with high priority labels Dec 3, 2020
@srikartati
Copy link
Contributor Author

Temporarily skipping registry generation check workflow that is there as part of code generation check.
This is done through PR #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority Needs to be taken care with high priority
Projects
None yet
Development

No branches or pull requests

1 participant