feat(csi): allow setting annotation on StorageClass to determine VolumeSnapshotClass #8646
+161
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meSnapshotClass Signed-off-by: Carlo Field <[email protected]>
Signed-off-by: Carlo Field <[email protected]>
Signed-off-by: Carlo Field <[email protected]>
|
For reference, this is the same PR I first opened in the old CSI plugin repo, before realising that repo is outdated. |
kaovilai
reviewed
Jan 23, 2025
Signed-off-by: Carlo Field <[email protected]>
Signed-off-by: Carlo Field <[email protected]>
kaovilai
reviewed
Jan 27, 2025
Signed-off-by: Carlo Field <[email protected]>
cfi2017
force-pushed
the
feat/storageclass-volumesnapshotclass-annotation
branch
from
2a931b5 to
e8c8283
Compare
reasonerjt
added
the
Needs triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to specify the desired VolumeSnapshotClass by annotation in the StorageClass.
An example use case here is Nutanix: The Nutanix CSI driver uses a single provisioner but allows for StorageClasses on either NFS (NutanixFiles) or Volumes (NutanixVolumes). These two StorageClasses require differently configured VolumeSnapshotClasses even though they use the same provisioner.
In Velero, currently, this is only supported by setting an annotation on every PVC you want to back up.
A more scalable approach is to allow setting a default for the StorageClass.
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.