-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement abort running backup job #2098
Comments
Adding to this, it would be nice to be able to:
We might be able to get some of this behavior for free if we move to running backups/restores in their own Pods/Jobs, per #1653 |
I started a backup job on a tainted node on which no restic workload was running until i added the appropriate toleration key. |
Should also handle aborting restores in progress |
I was stuck in similar situation. Started a backup job only to realize later that I forgot something important. Instead of waiting for 2+ hours, I decided to delete velero and re-installed it. We had a tight maintenance window so I took this path. A |
This would be easier to cancel the in-progress backup in #4772 |
I think this is a valid requirement, however currently the whole backup is running one reconcile action. |
Similar issue and requirement from production. Accidently left a namespace and objects in a backup job that didn't need it. No way to stop or abort the backup from going to the offsite storage bucket consuming space, bandwidth, money, and time. Desperately need a way to cleanly abort a task. The issue will only get more problematic with time as the dataset and workloads grow. |
smae here, i typed a wrong label selector and created a backup of my whole cluster... |
cc: @sseago @draghuram We can ignore retry on NotExists so it only retry on other errors. |
@kaovilai Watching delete might be helpful for cleaning up after questionable user actions, but I don't think |
Describe the problem/challenge you have
If one submits a backup job and forgets the narrowing select the system is blocked.
Describe the solution you'd like
I would like to be able to abort a job so the queue continues to work.
Anything else you would like to add:
Having short jobs that run every minute pile up very quickly
Environment:
velero version
Client:
Version: v1.2.0
Git commit: 5d00849
Server:
Version: v1.2.0
kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.6", GitCommit:"7015f71e75f670eb9e7ebd4b5749639d42e20079", GitTreeState:"clean", BuildDate:"2019-11-13T11:20:18Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:05:50Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Kubernetes installer & version: v1.15.3
Cloud provider or hardware configuration: Intel(R) Xeon(R) CPU E5-2650
OS (e.g. from
/etc/os-release
): Ubuntu 18.04.3 LTS (Bionic Beaver)The text was updated successfully, but these errors were encountered: