Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint version #81

Open
rajathagasthya opened this issue Apr 27, 2023 · 2 comments
Open

Update golangci-lint version #81

rajathagasthya opened this issue Apr 27, 2023 · 2 comments
Labels
kind/feature New feature or functionality added

Comments

@rajathagasthya
Copy link
Member

Is your feature request related to a problem? Please describe.

We should update golangci-lint to the latest version v1.52.2.

In addition, we should also remove the following linters as they are deprecated:

deadcode
structcheck
varcheck

Describe the solution you'd like

A new version of golangci-lint to be run during linting.

Describe alternatives you've considered

Keep the old version and miss out on improvements.

Additional context

@rajathagasthya rajathagasthya added the kind/feature New feature or functionality added label Apr 27, 2023
@yharish991
Copy link
Member

thanks @rajathagasthya for opening this issue, i created an issue to revisit the linter rules #43 a while back, but didn't have enough bandwidth to get back to that issue. However, i think we need to remove the deprecated linters and update the golangci-lint to the latest version.

@rajathagasthya
Copy link
Member Author

Good idea to do this and #43 together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or functionality added
Projects
None yet
Development

No branches or pull requests

2 participants