Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: vivliostyle parses incorrect syntax for ellipse #1425

Open
MoamenAbdelsattar opened this issue Dec 1, 2024 · 1 comment
Open

Bug: vivliostyle parses incorrect syntax for ellipse #1425

MoamenAbdelsattar opened this issue Dec 1, 2024 · 1 comment
Labels

Comments

@MoamenAbdelsattar
Copy link
Contributor

After looking at Apollo 8 sample source code, I found that vivliostyle parses incorrect syntax for ellipse, which is -epubx-shape-outside: ellipse(50%, 55%, 46%, 46%);. After correcting it to the correct syntax ellipse(44% 40% at 51% 54%), vivliostyle.js didn't parse it correctly;
image

@MurakamiShinyu
Copy link
Member

Thanks for the report. The -epubx- properties were made long time ago in https://github.com/sorotokin/adaptive-layout/ and Vivliostyle.js inherited it.

Indeed, currently modern browsers support shape-outside and the old -epubx-shape-outside implementation should be no longer necessary. I will consider fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants