Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #434 (subnet sizes != /16) #438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #434 (subnet sizes != /16) #438

wants to merge 1 commit into from

Conversation

ValentinVoigt
Copy link

This should fix #434. I took the freedom to simplify the command you proposed a bit. I also removed private_network_test_ip, which had the same problem with subnet size. My IDE ran shfmt on the .sh-files; I kept the reformatting, if you don't mind.

I also tried running e2e-tests (see GH-437), but stopped the execution, when tests where spamming dozens of errors quickly (image 'fedora-38' not found). I also had random connection issues after server creation. I did not investigate further at this point. I don't think they were related to my changes.

Random connection problems:

Error creating instance: timeout after 00:01:00
Instance creation for test-e9acedda-master1 failed. Try rerunning the create command.

Aborted test results:

config-sshport-image.yaml  IMAGE=alma-8 SSHPORT=22         error    done      test-15c94339
config-sshport-image.yaml  IMAGE=alma-8 SSHPORT=222        error    done      test-c59dc574
config-sshport-image.yaml  IMAGE=alma-9 SSHPORT=22         ok       done      test-3a378dbe
config-sshport-image.yaml  IMAGE=alma-9 SSHPORT=222        error    done      test-e9acedda
config-sshport-image.yaml  IMAGE=debian-11 SSHPORT=22      ok       done      test-77bf45fe
config-sshport-image.yaml  IMAGE=debian-11 SSHPORT=222     ok       done      test-fe655f1c
config-sshport-image.yaml  IMAGE=debian-12 SSHPORT=222     ok       done      test-e16755b9
config-sshport-image.yaml  IMAGE=fedora-38 SSHPORT=222     pending  creating  test-06bdf688
config-sshport-image.yaml  IMAGE=rocky-8 SSHPORT=22        ok       done      test-34ca1517
config-sshport-image.yaml  IMAGE=rocky-8 SSHPORT=222       error    done      test-48a902f8
config-sshport-image.yaml  IMAGE=rocky-9 SSHPORT=22        ok       done      test-3c4c5d45
config-sshport-image.yaml  IMAGE=ubuntu-20.04 SSHPORT=222  ok       done      test-9b2fbf59
config-sshport-image.yaml  IMAGE=ubuntu-22.04 SSHPORT=222  ok       done      test-86176827
config-sshport-image.yaml  IMAGE=ubuntu-24.04 SSHPORT=222  ok       done      test-b7c132d6

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vitobotta
Copy link
Owner

Thanks for the PR! It's a bit delicate change so I will need to test it throughly when I have more time.

@ValentinVoigt
Copy link
Author

I very much agree with you. This should not be rushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use private networks with subnet size != 16
2 participants
@ValentinVoigt @vitobotta