From 829caf040cd9929989747fa1bde3f9b4949ff5a5 Mon Sep 17 00:00:00 2001 From: Dirkjan Bussink Date: Wed, 29 Jan 2025 17:27:41 +0100 Subject: [PATCH] Fix overflow check Signed-off-by: Dirkjan Bussink --- go/vt/vtctl/grpcvtctldserver/server.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/go/vt/vtctl/grpcvtctldserver/server.go b/go/vt/vtctl/grpcvtctldserver/server.go index 40ce7871902..ec9fd80db89 100644 --- a/go/vt/vtctl/grpcvtctldserver/server.go +++ b/go/vt/vtctl/grpcvtctldserver/server.go @@ -1510,7 +1510,7 @@ func (s *VtctldServer) GetBackups(ctx context.Context, req *vtctldatapb.GetBacku totalBackups := len(bhs) if req.Limit > 0 { - if req.Limit > math.MaxInt { + if int(req.Limit) < 0 { return nil, fmt.Errorf("limit %v exceeds maximum allowed value %v", req.DetailedLimit, math.MaxInt) } totalBackups = int(req.Limit) @@ -1518,7 +1518,7 @@ func (s *VtctldServer) GetBackups(ctx context.Context, req *vtctldatapb.GetBacku totalDetailedBackups := len(bhs) if req.DetailedLimit > 0 { - if req.DetailedLimit > math.MaxInt { + if int(req.DetailedLimit) < 0 { return nil, fmt.Errorf("detailed_limit %v exceeds maximum allowed value %v", req.DetailedLimit, math.MaxInt) } totalDetailedBackups = int(req.DetailedLimit)