Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request to add laytest nsfplay and laytest beta to zxtune? #2188

Open
juanreina921 opened this issue Feb 2, 2021 · 6 comments
Open

request to add laytest nsfplay and laytest beta to zxtune? #2188

juanreina921 opened this issue Feb 2, 2021 · 6 comments

Comments

@juanreina921
Copy link

Hey, When it comes to gme for nsf playback, it hasn't been updated for a long time now, and nsf playback is far from accurate, failing to play new nsfs correctly, or not playing them at all. I tested them out with nsfplay, and they work and play correctly. I think it's made with c pluss pluss, and using a version suitable with zxtune. Latest beta and sorce, recommended.
https://ci.appveyor.com/project/bbbradsmith/nsfplay/branch/master/artifacts
Don't worry, link is the same for new versions of nsfplay. I will atach zip with some nsfs, so you can test for yourself.

@juanreina921
Copy link
Author

Heres the archive. There could be more, but this is all I've got for now. don't worry the files will stay there for 21 days. http://www.fileconvoy.com/dfl.php?id=g6c2ee0334626a175100032605307a3c906d14eefc5

@vitamin-caig
Copy link
Owner

I'm not sure nfsplay will fit zxtune requirements for 3rdparty library.

@juanreina921
Copy link
Author

Is there something wrong?

@vitamin-caig
Copy link
Owner

At first glance:

  1. Japanese comments
  2. Code is not thread-safe and event thread-aware
  3. Almost no metadata accessible (only title)
  4. Unnecessary coupling with UI-related code which is platform-dependent

@juanreina921
Copy link
Author

Oh, I see. Isn't there a player that could be used instead of gme for nsf? Was thinking nezplug pluss pluss, but that too, has japanese comments.

@caallaki
Copy link

caallaki commented Feb 14, 2021

There is NotsoFatso

IDK if it's suitable for zxtune usage, but it's a really great engine

http://slickproductions.org/notsofatso.php

http://forums.nesdev.com/viewtopic.php?f=6&t=4653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants