Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline Failure on PR #993 Due to Potential Hardcoded Class Hash #27

Open
neotheprogramist opened this issue Nov 9, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@neotheprogramist
Copy link
Member

After developing a new where API in PR #993, we have encountered a failure in the pipeline during the cargo test phase (details here: CI Run).

It appears that the issue may stem from modifications made to classes, possibly due to a hardcoded class hash. This is preventing the merging of PR dojoengine#993 as the pipeline fails to pass.

The task at hand is to verify whether the problem is indeed due to a hardcoded class hash. If confirmed, the necessary corrections should be implemented. If the hardcoded hash is not the cause, further investigation is required to identify the root of the problem and apply a fix.

@neotheprogramist neotheprogramist added the bug Something isn't working label Nov 9, 2023
@matzayonc
Copy link

Update:
Minimal problem: $ cargo nextest run --all-features tests::entities_test::tests::entities_test fails.
Observations:

  • passes on local
  • fails on CI
  • fails on fresh clone

Conclusions:

  • Files causing a problem are generated and outside of VCS

Possible fixes:

  • Find a crate or contract that isn't build and add it to worflow or workspace

@matzayonc
Copy link

clone -> build -> checkout -> test works, but clone -> checkout -> build -> test does not.

@matzayonc
Copy link

Updated hardcoded address, and investigated possible alternatives.

  • Capturing output of a program is unstable like shown here
  • Modification of migraction contract passed to function - produces unclean code
  • Modification of the return value as it isn't used almost anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants