You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description:
In the hyperledger/besu-verkle-trie repository, each node has a dirty flag indicating whether it has been modified since the last database write. This flag is crucial for determining whether commitments need to be recalculated. However, it has been observed that the CommitVisitor class does not appropriately reset this flag to clean for nodes that have been written to the database. This oversight could lead to unnecessary recalculations and affect the efficiency of the trie operations.
Expected Behavior:
Testing: A new test case should be created to verify that the root node's dirty flag is set to clean after the commit() method is executed. This test will help in asserting the correct behavior of the node state post-commit.
Code Modification: If the newly created test fails, it indicates a requirement for modifying the CommitVisitor implementation. The modification should ensure that once a node is stored in the database, its dirty flag is set to clean, indicating no further modifications are pending.
The text was updated successfully, but these errors were encountered:
Description:
In the hyperledger/besu-verkle-trie repository, each node has a
dirty
flag indicating whether it has been modified since the last database write. This flag is crucial for determining whether commitments need to be recalculated. However, it has been observed that theCommitVisitor
class does not appropriately reset this flag toclean
for nodes that have been written to the database. This oversight could lead to unnecessary recalculations and affect the efficiency of the trie operations.Expected Behavior:
dirty
flag is set toclean
after thecommit()
method is executed. This test will help in asserting the correct behavior of the node state post-commit.CommitVisitor
implementation. The modification should ensure that once a node is stored in the database, itsdirty
flag is set toclean
, indicating no further modifications are pending.The text was updated successfully, but these errors were encountered: