Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3-4-stable branch? #38

Open
padi opened this issue May 23, 2018 · 2 comments
Open

3-4-stable branch? #38

padi opened this issue May 23, 2018 · 2 comments
Assignees
@himanshumishra31

Comments

@padi
Copy link
Contributor

padi commented May 23, 2018

According to the installation instructions, the branch option for the gem in the gemfile is important.

Is this completely compatible with Spree 3.4? I've tried master with a Spree 3.4 sandbox, and it seems to calculate the tax anyway. Just not sure why there's no 3-4-stable branch.
@tanmay3011
Copy link
Member

tanmay3011 commented May 29, 2018 •
edited
Loading

Hey @padi,

master branch is completely compatible with Spree 3.4. We have started following the spree-contrib extensions format of supporting all versions on the master branch. Documentation seems to be outdated, we'll update it soon. Thanks for pointing this issue.

@himanshumishra31
Copy link
Contributor

Hi @padi

Readme has been updated. Thanks for pointing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himanshumishra31 himanshumishra31

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@padi @tanmay3011 @himanshumishra31