Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new models #49

Closed
vincentarelbundock opened this issue Sep 11, 2021 · 48 comments
Closed

Support new models #49

vincentarelbundock opened this issue Sep 11, 2021 · 48 comments

Comments

@vincentarelbundock
Copy link
Owner

vincentarelbundock commented Sep 11, 2021

IF THE MODEL YOU WOULD LIKE TO SUPPORT IS NOT LISTED BELOW, PLEASE OPEN A NEW ISSUE.

It is often very easy to add support for new models. If you would like to help us do it (thanks!!!), please read this vignette on marginaleffects extensions: https://vincentarelbundock.github.io/marginaleffects/articles/extensions.html

marginaleffects only supports modeling packages released on CRAN. If you would like to add support for a non-CRAN package, your code can be hosted in the user-submitted (b
ut unsupported) code library in the vignette above.

If you cannot contribute code to support a new model, and if that model is not listed below, please open a new issue with a working example using a small publicly available dataset.

Seems possible

Challenges

Existing issues (with some notes)

predict problem

vcov problem

Categorical / Multinomial DV

  • VGAM::vglm: not just multinomial
  • VGAM::vgam

Not currently planned

Spatial regression

Spatial regression models typically rely on very different data structures, and are currently considered out of scope for marginaleffects

Multi-row data structure

Some multinomial models require dataset to be presented with one observation-choice combination per row. The whole marginaleffects infrastrcture is designed to create contrasts 1 row at a time, so we cannot support these.

No formula interface

Very different object structure

  • metafor: Very different input data. Likely very difficult to support. Would need code submission from an expert contributor. Support: metafor (rma, rma.mv) #604
  • lavaan: Vincent has no experience with this package. We could consider this, but it would require serious code contributions. Support: lavaan #499
  • R-INLA: Very different and unlikely. Support: R-INLA #342
  • Apollo for choice models. Seems extremely idiosyncratic, and does not appear to supply any of the standard methods such as vcov(), coef(), or predict(). Supporting this is likely to be a major challenge. Vincent is unlikely to do this himself without significant help (or more likely a quasi-complete PR) from a contributor. https://cran.r-project.org/web/packages/apollo/index.html
  • cmprsk::crr: Seems very different. Vincent will not implement this unless someone is willing to help.

Already supported via tidymodels or mlr3

Not on CRAN

  • bigmlogit: checked on 2022-06-02
  • mixor: checked on 2022-03-10
  • mnlogit: checked on 2023-01-11
  • tobit1: checked on 2023-01-11
  • ZBZIMM: Support: ZBZIMM #541

Supported by other packages

@strengejacke

This comment has been minimized.

@vincentarelbundock

This comment has been minimized.

@vincentarelbundock

This comment has been minimized.

Repository owner deleted a comment from Jyasmeen Jan 8, 2022
@dustingilbreath

This comment was marked as resolved.

@vincentarelbundock

This comment was marked as resolved.

@dustingilbreath

This comment was marked as resolved.

@vincentarelbundock

This comment was marked as resolved.

@dustingilbreath

This comment was marked as resolved.

@TysonStanley

This comment was marked as resolved.

@vincentarelbundock

This comment was marked as resolved.

@vincentarelbundock

This comment was marked as resolved.

@TysonStanley

This comment was marked as resolved.

@TysonStanley

This comment was marked as resolved.

@vincentarelbundock

This comment was marked as duplicate.

@TysonStanley

This comment was marked as resolved.

@strengejacke

This comment was marked as resolved.

@go-bayes

This comment was marked as off-topic.

@vincentarelbundock

This comment was marked as off-topic.

@go-bayes

This comment was marked as off-topic.

@vincentarelbundock

This comment was marked as off-topic.

@DrJerryTAO

This comment was marked as outdated.

@MarcRieraDominguez

This comment was marked as outdated.

@mattwarkentin

This comment was marked as outdated.

@vincentarelbundock

This comment was marked as outdated.

@vincentarelbundock

This comment was marked as duplicate.

@jarmasmuguerza

This comment was marked as duplicate.

@lorenzoFabbri

This comment was marked as duplicate.

@DrJerryTAO

This comment was marked as duplicate.

@lachanskim

This comment was marked as outdated.

@vincentarelbundock

This comment was marked as outdated.

@lachanskim

This comment was marked as outdated.

@vincentarelbundock

This comment was marked as outdated.

@lachanskim

This comment was marked as outdated.

@lachanskim

This comment was marked as outdated.

@scfmolina

This comment was marked as outdated.

@vincentarelbundock

This comment was marked as outdated.

@scfmolina

This comment was marked as outdated.

@vincentarelbundock

This comment was marked as outdated.

@scfmolina

This comment was marked as outdated.

@vincentarelbundock

This comment was marked as outdated.

@ASKurz ASKurz mentioned this issue Oct 26, 2023
@hongyunsoo

This comment has been minimized.

@aghaynes

This comment has been minimized.

@vincentarelbundock

This comment has been minimized.

Repository owner locked and limited conversation to collaborators Jun 6, 2024
@vincentarelbundock vincentarelbundock added the enhancement New feature or request label Sep 26, 2024
@vincentarelbundock vincentarelbundock removed the enhancement New feature or request label Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests