Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I like this. Ideally we would use Gson versions (which would map to the API version) in addition to this. Then only invalidate the cache if we know there will be a breaking change. This would also help us a bit with any other persistence (like turnstile). #328

Closed
zerze1 opened this issue Feb 24, 2023 · 1 comment

Comments

@zerze1
Copy link

zerze1 commented Feb 24, 2023

          I like this. Ideally we would use Gson versions (which would map to the API version) in addition to this. Then only invalidate the cache if we know there will be a breaking change. This would also help us a bit with any other persistence (like turnstile).

https://sites.google.com/site/gson/gson-user-guide#TOC-Versioning-Support
Name changes: https://futurestud.io/tutorials/gson-model-annotations-multiple-deserialization-names-with-serializedname
http://memorynotfound.com/gson-versioning-support/

Originally posted by @kvenn in vimeo/vimeo-networking-java#252 (comment)

@aaronm67
Copy link
Collaborator

aaronm67 commented Feb 24, 2023

This is not for this package, it looks like it's for a android package potentially

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants