Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement :shrink() #7

Open
viluon opened this issue Dec 28, 2016 · 3 comments
Open

Implement :shrink() #7

viluon opened this issue Dec 28, 2016 · 3 comments
Assignees
Milestone

Comments

@viluon
Copy link
Owner

viluon commented Dec 28, 2016

Implement a method for shrinking a buffer using the teletext characters of CC 1.76+.

@viluon
Copy link
Owner Author

viluon commented Jan 3, 2017

Huh, that's quite inefficient though - isn't it? We wouldn't need a buffer with 3 pixel properties, we'd only utilise the background colour. Therefore pixels could only be numbers instead of arrays - we need a new buffer library for this, or somehow branch the existing buffer... I know @exerro solved this by using a preprocessor (which is both ugly and against the Desktox development process philosophy). So it'd probably be best to just have another module, but that's twice the code to maintain :/

@viluon
Copy link
Owner Author

viluon commented Jan 23, 2017

Shrinking should be a feature of another (external) library, and is outside the scope of desktox.buffer. Rendering a pixel-perfect buffer to a terminal buffer should "shrink" automagically, so the functionality will essentially be there, once pixel-perfect is implemented.

@viluon viluon closed this as completed Jan 23, 2017
@viluon viluon added this to the 0.1 milestone Mar 6, 2017
@viluon
Copy link
Owner Author

viluon commented Mar 6, 2017

Actually, thanks to #16, we can resolve #10, for which we'll need :shrink().

@viluon viluon reopened this Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant