Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "semver" in package.json #1676

Closed
mschakulat opened this issue Jun 6, 2024 · 5 comments
Closed

Missing "semver" in package.json #1676

mschakulat opened this issue Jun 6, 2024 · 5 comments
Labels

Comments

@mschakulat
Copy link

mschakulat commented Jun 6, 2024

Description

In release 0.4.173 there is no "semver" dependency in the package.json but the package is imported in vike/node/plugin/plugins/importUserCode/v1-design/assertExtensions.ts.

As "semver" is a dependency of @brillout/release-me (which is a devDependency), building the application with --prod will fail.

@brillout
Copy link
Member

brillout commented Jun 6, 2024

Isn't it included in Node.js? The CI is passing so it apparently is.

@mschakulat
Copy link
Author

As far as I can see the CI just installs all dependencies, including devDependencies so it won't fail. But using vike when installing deps with --prod will fail. Or am i missing something?

@brillout
Copy link
Member

brillout commented Jun 6, 2024

Indeed, let me fix that.

@brillout
Copy link
Member

brillout commented Jun 6, 2024

Fix released in 0.4.174.

@brillout
Copy link
Member

brillout commented Jun 6, 2024

(Btw. in case your company is up for it: sponsoring makes a massive difference. Also happy to meet folks IRL in Germany.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants