From 33875ce0427fbe41ec0a3a48278935e1c6cbd2f1 Mon Sep 17 00:00:00 2001 From: Michael DeFazio Date: Tue, 17 Dec 2024 15:52:01 -0500 Subject: [PATCH] QA fixes to align with the new borealis theme (#204080) ## Summary Fixes https://github.com/elastic/search-team/issues/8647 * ~Updates non-status colors on badges and panels that were using `success` to `accentSecondary`~. Some badges remain as `success`, changed non-status badges to `primary` * New guidance requests that buttons are changed to either `text` or `primary` rather than using `accentSecondary` * Changes serverless welcome banner background to match stack * Updates search labs banner to use right color <-- Background uses `accentSecondary` and keeps `success` button [(Slack thread](https://elastic.slack.com/archives/C7QC1JV6F/p1734103814782069)) * Adds border around code blocks so it is visible in dark mode. | | | |--------|--------| | **Notebooks button:** | ![CleanShot 2024-12-13 at 09 27 37@2x](https://github.com/user-attachments/assets/1e1aeb27-12d3-4a20-829a-6e4720e8dedf) ![CleanShot 2024-12-13 at 09 28 21@2x](https://github.com/user-attachments/assets/2dfb97f0-10f4-4b7c-8b92-19c6e937b341) | | **Getting started Connection details:** | ![CleanShot 2024-12-16 at 09 53 56@2x](https://github.com/user-attachments/assets/1404901e-2079-4046-918e-754d8e49e750) | | **Welcome banner on Serverless: Removes primary background** | ![CleanShot 2024-12-13 at 09 37 56@2x](https://github.com/user-attachments/assets/99243bd6-75b0-4cd2-8f74-f1d00af3ad07) | | **Search labs banner:** | ![CleanShot 2024-12-16 at 09 14 11@2x](https://github.com/user-attachments/assets/d0c43e88-87a9-4929-994a-ac053ec0024a) ![CleanShot 2024-12-16 at 09 13 04@2x](https://github.com/user-attachments/assets/31d9b2b3-9ce9-4292-8f85-19a6dd31c9b2) | | **Borders in dark mode for code blocks** | ![CleanShot 2024-12-13 at 09 48 27@2x](https://github.com/user-attachments/assets/f3a002c4-bf3e-4d33-bce5-862477db073c) | | Crawler updates | ![CleanShot 2024-12-16 at 15 16 04@2x](https://github.com/user-attachments/assets/93c9e7e7-7009-4f2a-9b0b-0b127a5979bf) ![CleanShot 2024-12-16 at 15 16 51@2x](https://github.com/user-attachments/assets/f71f1f38-7e66-4cf5-8ec1-a67fe9dbf9f5) ![CleanShot 2024-12-16 at 15 24 15@2x](https://github.com/user-attachments/assets/62cc7a28-94cc-437c-b149-3ca79d334bb0) | | Pipelines callouts, badges, and buttons | ![CleanShot 2024-12-16 at 15 25 12@2x](https://github.com/user-attachments/assets/d02efa40-71d8-4140-9170-07e135b78d24) ![CleanShot 2024-12-16 at 15 25 46@2x](https://github.com/user-attachments/assets/f7ba21e3-acc8-4513-bca0-5cbb4c6ce06c) | --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> --- .../kbn-search-api-panels/components/cloud_details.tsx | 2 +- .../authentication_panel/authentication_panel_actions.tsx | 2 +- .../crawler/domain_management/domains_panel.tsx | 2 +- .../pipelines/ml_inference/add_ml_inference_button.tsx | 2 +- .../ml_inference/text_expansion_callout/deploy_model.tsx | 8 ++++---- .../components/search_index/pipelines/pipelines.tsx | 2 +- .../shared/search_labs_banner/search_labs_banner.tsx | 3 ++- .../inline_editable_table/inline_editable_table.tsx | 2 +- .../dev_tools_console_code_block.tsx | 2 +- .../home/index_list/details_page/semantic_text_banner.tsx | 4 ++-- .../public/components/notebooks_button.tsx | 4 ++-- .../public/application/components/overview.scss | 6 +----- .../public/application/components/overview.tsx | 5 +---- 13 files changed, 19 insertions(+), 25 deletions(-) diff --git a/packages/kbn-search-api-panels/components/cloud_details.tsx b/packages/kbn-search-api-panels/components/cloud_details.tsx index df2cc6bb6837d..0c406b4c31855 100644 --- a/packages/kbn-search-api-panels/components/cloud_details.tsx +++ b/packages/kbn-search-api-panels/components/cloud_details.tsx @@ -97,7 +97,7 @@ export const CloudDetailsPanel = ({ - + { ) : currentAuth === null ? ( enableEditing(currentAuth)} diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_panel.tsx b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_panel.tsx index 41af7db78b6be..60f2e52211972 100644 --- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_panel.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_panel.tsx @@ -47,7 +47,7 @@ export const DomainsPanel: React.FC = () => { data-telemetry-id="entSearchContent-crawler-domainManagement-addDomain-addDomain" onClick={openFlyout} size="s" - color="success" + color="primary" iconType="plusInCircle" > {i18n.translate('xpack.enterpriseSearch.crawler.addDomainFlyout.openButtonLabel', { diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_ml_inference_button.tsx b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_ml_inference_button.tsx index 1f8bc30e2903c..c7c296a443ebf 100644 --- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_ml_inference_button.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_ml_inference_button.tsx @@ -79,7 +79,7 @@ const AddButton: React.FC<{ + - + - +

{i18n.translate( 'xpack.enterpriseSearch.content.index.pipelines.textExpansionCallOut.title', @@ -87,7 +87,7 @@ export const DeployModel = ({ > { hasIndexIngestionPipeline ? ( - + {i18n.translate( 'xpack.enterpriseSearch.content.indices.pipelines.ingestionPipeline.customBadge', { defaultMessage: 'Custom' } diff --git a/x-pack/plugins/enterprise_search/public/applications/shared/search_labs_banner/search_labs_banner.tsx b/x-pack/plugins/enterprise_search/public/applications/shared/search_labs_banner/search_labs_banner.tsx index d9f1be314a56e..a1b3302cd35a8 100644 --- a/x-pack/plugins/enterprise_search/public/applications/shared/search_labs_banner/search_labs_banner.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/shared/search_labs_banner/search_labs_banner.tsx @@ -36,10 +36,11 @@ export const SearchLabsBanner: React.FC = () => { ({ iconType="plusInCircle" disabled={isEditing} onClick={editNewItem} - color="success" + color="primary" data-test-subj="inlineEditableTableActionButton" > {addButtonText || diff --git a/x-pack/plugins/enterprise_search/public/applications/vector_search/components/dev_tools_console_code_block/dev_tools_console_code_block.tsx b/x-pack/plugins/enterprise_search/public/applications/vector_search/components/dev_tools_console_code_block/dev_tools_console_code_block.tsx index d48011d54cdff..46a60456be7cc 100644 --- a/x-pack/plugins/enterprise_search/public/applications/vector_search/components/dev_tools_console_code_block/dev_tools_console_code_block.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/vector_search/components/dev_tools_console_code_block/dev_tools_console_code_block.tsx @@ -39,7 +39,7 @@ export const DevToolsConsoleCodeBlock: React.FC = return ( - + - + - + {isPlatinumLicense ? platinumLicenseMessage : defaultLicenseMessage} diff --git a/x-pack/plugins/search_notebooks/public/components/notebooks_button.tsx b/x-pack/plugins/search_notebooks/public/components/notebooks_button.tsx index 66fc50a03ddd7..d71cade82aae7 100644 --- a/x-pack/plugins/search_notebooks/public/components/notebooks_button.tsx +++ b/x-pack/plugins/search_notebooks/public/components/notebooks_button.tsx @@ -30,7 +30,7 @@ export const SearchNotebooksButton = ({ if (activeView) { return ( div { padding-bottom: 0; padding-top: 0; @@ -13,4 +9,4 @@ .serverlessSearchCloudDetailsCopyPanel { word-break: break-all; -} \ No newline at end of file +} diff --git a/x-pack/plugins/serverless_search/public/application/components/overview.tsx b/x-pack/plugins/serverless_search/public/application/components/overview.tsx index 678eadb6b5cb6..d20706a6aa804 100644 --- a/x-pack/plugins/serverless_search/public/application/components/overview.tsx +++ b/x-pack/plugins/serverless_search/public/application/components/overview.tsx @@ -14,7 +14,6 @@ import { EuiIcon, EuiPageTemplate, EuiPanel, - EuiText, EuiBadge, } from '@elastic/eui'; import { i18n } from '@kbn/i18n'; @@ -96,9 +95,7 @@ export const ElasticsearchOverview = () => { return ( - - - +