diff --git a/.github/workflows/mediasoup-worker.yaml b/.github/workflows/mediasoup-worker.yaml index 6851658a8f..74b4a36717 100644 --- a/.github/workflows/mediasoup-worker.yaml +++ b/.github/workflows/mediasoup-worker.yaml @@ -11,6 +11,7 @@ concurrency: jobs: ci: strategy: + fail-fast: false matrix: build: - os: ubuntu-20.04 @@ -61,6 +62,7 @@ jobs: CXX: ${{ matrix.build.cxx }} MEDIASOUP_SKIP_WORKER_PREBUILT_DOWNLOAD: 'true' MEDIASOUP_LOCAL_DEV: 'true' + MEDIASOUP_BUILDTYPE: 'Debug' steps: - name: Checkout diff --git a/worker/test/src/RTC/TestNackGenerator.cpp b/worker/test/src/RTC/TestNackGenerator.cpp index bb9744188b..b4dfd359b5 100644 --- a/worker/test/src/RTC/TestNackGenerator.cpp +++ b/worker/test/src/RTC/TestNackGenerator.cpp @@ -139,6 +139,38 @@ void validate(std::vector& inputs) } }; +SCENARIO("ISSUE 1366: https://github.com/versatica/mediasoup/issues/1366") +{ + SECTION("foo") + { + REQUIRE(RTC::SeqManager::IsSeqLowerThan(10000, 40000) == true); + REQUIRE(RTC::SeqManager::IsSeqLowerThan(40000, 60000) == true); + REQUIRE(RTC::SeqManager::IsSeqLowerThan(10000, 60000) == false); + } + + // SECTION("std::set") + // { + // std::set::SeqLowerThan> recoveredList; + + // recoveredList.insert(10000); + // recoveredList.insert(40000); + // recoveredList.insert(60000); + + // REQUIRE(recoveredList.size() == 3); + // } + + SECTION("absl::btree_set") + { + absl::btree_set::SeqLowerThan> recoveredList; + + recoveredList.insert(10000); + recoveredList.insert(40000); + recoveredList.insert(60000); + + REQUIRE(recoveredList.size() == 3); + } +} + SCENARIO("NACK generator", "[rtp][rtcp]") { SECTION("no NACKs required")