Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "announced ip" to "announced address" #1323

Closed
7 tasks done
ibc opened this issue Feb 1, 2024 · 0 comments · Fixed by #1324
Closed
7 tasks done

Rename "announced ip" to "announced address" #1323

ibc opened this issue Feb 1, 2024 · 0 comments · Fixed by #1324
Assignees
@ibc
Labels
enhancement
Milestone
v3 updates

Comments

@ibc
Copy link
Member

ibc commented Feb 1, 2024 •
edited
Loading

As per discussion in #1322:

Tasks:

  • Rust: In TransportListenInfo rename announced_ip to announced_address.
  • Rust: In IceCandidate rename ip to address.
  • Rust: In TransportTuple rename local_ip to local_address.
  • Node: In TransportListenInfo rename announcedIp to announcedAddress and keep backwards compatibility.
  • Node: In IceCandidate rename ip to address and keep backwards compatibility.
  • Node: In TransportTuple rename localIp to localAddress and keep backwards compatibility.
  • Docs: Update.
@ibc ibc added the enhancement label Feb 1, 2024
@ibc ibc added this to the v3 updates milestone Feb 1, 2024
@ibc ibc mentioned this issue Feb 1, 2024
Merged
@ibc ibc self-assigned this Feb 1, 2024
ibc added a commit that referenced this issue Feb 1, 2024
@ibc
Rename "announced ip" to "announced address"
d19c00b 
Fixes #1323

- Rust: In `TransportListenInfo` rename `announced_ip` to `announced_address`.
- Rust: In `IceCandidate` rename `ip` to `address`.
- Rust: In `TransportTuple` rename `local_ip` to `local_address`.
- Node: In `TransportListenInfo` rename `announcedIp` to `announcedAddress` and keep backwards compatibility.
- Node: In `IceCandidate` rename `ip` to `address` and keep backwards compatibility.
- Node: In `TransportTuple` rename `localIp` to `localAddress` and keep backwards compatibility.

**NOTE:** Why has been `TransportTuple.localIp` renamed to `TransportTuple.localAddress`? Because indeed its value is an announced address if a hostname was given in `announcedAddress` in a `TransportListenInfo`.
@ibc ibc mentioned this issue Feb 1, 2024
Merged
@ibc ibc closed this as completed in #1324 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibc ibc

Labels
enhancement
Milestone
v3 updates
Development

Successfully merging a pull request may close this issue.

Rename "announced ip" to "announced address" versatica/mediasoup
1 participant
@ibc