Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flatbuffers] enableUdp/Tcp and forceUdp/Tcp in createWebRtcTransport() are completely missing #1184

Closed
ibc opened this issue Oct 19, 2023 · 3 comments · Fixed by #1185
Closed
Labels
Milestone

Comments

@ibc
Copy link
Member

ibc commented Oct 19, 2023

Bug Report

Those things are missing in flatbuffers branch so passing enableUdp: false (for example) to router.createWebRtcTransport() is completely ignored.

@ibc ibc added the bug label Oct 19, 2023
@ibc ibc added this to the v3 updates milestone Oct 19, 2023
@ibc ibc mentioned this issue Oct 19, 2023
7 tasks
@ibc
Copy link
Member Author

ibc commented Oct 19, 2023

But the problem is that enable_udp and force_udp (same for TCP) are not even defined in FBS...

ibc added a commit that referenced this issue Oct 19, 2023
Fixes #1184

### Details

- No idea how, but flatbuffers branch misses `enableUdp`, `enableTcp`, and `preferUdp` and `preferTcp` options when creating a `WebRtcTransport` with a `WebRtcServer`. This was implemented in v3.

### TODO

Rust side, but I prefer to have the Node + C++ sides approved first.

### NOTE

I'm extremely worried that something else may have been lost, specially in `WebRtcServer` cpp and hpp files.
@jmillan
Copy link
Member

jmillan commented Oct 23, 2023

We can close this, right @ibc?

@ibc
Copy link
Member Author

ibc commented Oct 23, 2023

Yes.

@ibc ibc closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants