From b559e4d968fab9fdc35beb6abbd75d2bf59366de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Luis=20Mill=C3=A1n?= Date: Wed, 22 May 2024 15:27:37 +0200 Subject: [PATCH] prebuilt working --- .../workflows/mediasoup-worker-prebuild.yaml | 9 ++--- npm-scripts.mjs | 40 ------------------- 2 files changed, 3 insertions(+), 46 deletions(-) diff --git a/.github/workflows/mediasoup-worker-prebuild.yaml b/.github/workflows/mediasoup-worker-prebuild.yaml index 0f7d9b1128..203810a3d6 100644 --- a/.github/workflows/mediasoup-worker-prebuild.yaml +++ b/.github/workflows/mediasoup-worker-prebuild.yaml @@ -1,11 +1,9 @@ name: mediasoup-worker-prebuild # Only trigger on GitHub releases. -# on: - # release: - # types: [published] - -on: [pull_request, workflow_dispatch] +on: + release: + types: [published] jobs: ci: @@ -69,5 +67,4 @@ jobs: - name: Upload mediasoup-worker prebuilt binary uses: softprops/action-gh-release@v1 with: - tag_name: addon-test-5 files: worker/prebuild/libmediasoup-worker-*.tgz diff --git a/npm-scripts.mjs b/npm-scripts.mjs index bdd7427d08..1c1fd22f44 100644 --- a/npm-scripts.mjs +++ b/npm-scripts.mjs @@ -598,46 +598,6 @@ async function downloadPrebuiltWorker() { `downloadPrebuiltWorker() | failed to give execution permissions to the mediasoup-worker prebuilt binary: ${error}` ); } - - // Let's confirm that the fetched mediasoup-worker prebuit binary does - // run in current host. This is to prevent weird issues related to - // different versions of libc in the system and so on. - // So run mediasoup-worker without the required MEDIASOUP_VERSION env and - // expect exit code 41 (see main.cpp). - - logInfo( - 'downloadPrebuiltWorker() | checking fetched mediasoup-worker prebuilt binary in current host' - ); - - try { - const resolvedBinPath = path.resolve(WORKER_RELEASE_BIN_PATH); - - // This will always fail on purpose, but if status code is 41 then - // it's good. - execSync(`"${resolvedBinPath}"`, { - stdio: ['ignore', 'ignore', 'ignore'], - // Ensure no env is passed to avoid accidents. - env: {}, - }); - } catch (error) { - if (error.status === 41) { - logInfo( - 'downloadPrebuiltWorker() | fetched mediasoup-worker prebuilt binary is valid for current host' - ); - - resolve(true); - } else { - logError( - `downloadPrebuiltWorker() | fetched mediasoup-worker prebuilt binary fails to run in this host [status:${error.status}]` - ); - - try { - fs.unlinkSync(WORKER_RELEASE_BIN_PATH); - } catch (error2) {} - - resolve(false); - } - } }) .on('error', error => { logError(