Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elite_Vaf_Model_Observer::bootsrap set process url via configuration option #64

Open
kylecannon opened this issue Sep 29, 2013 · 1 comment

Comments

@kylecannon
Copy link
Member

For the product to be more extendable instead of calling the VF_Singleton:: getInstance()->setProcessURL(); with no configuration option change (SEE: https://github.com/vehiclefits/vfmagento/blob/master/app/code/local/Elite/Vaf/Model/Observer.php#L40) how about making it a configuration option to be able to change it ion the config.ini file?

@joshribakoff
Copy link
Member

The Magento extension is not a framework - that's what the library repo is for. I think when in doubt we should do what Mac does - keep things simple.

What would be the use case for this? If someone is overriding the AJAX logic & changing the URL the AJAX hits, they can just override the observer & inject their own values. Its a developer oriented change.

The config.ini is for settings that users want to change (not developers). Maybe I'm wrong but it just seems like something no user would use, and would be "cleaner" for a developer to do by overriding the bootstrap event with his own logic. May make sense to move it a function in the observer class, so someone overriding the observer only has to override the value that returns this URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants