Adds default selectorLabels to topologySpreadConstraints if not otherwise specified. #429
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone defines one or more entries in the `topologySpreadConstraints` list and does not define the `labelSelectors.matchLabels` keys then default values will be added. Most people are likely going to want the default selectorLabels so the spread constraints match what they are deploying with this chart.
bderrly
force-pushed
the
default-topology-constraints
branch
from
076c5ec to
ed379a9
Compare
pront
reviewed
Dec 2, 2024
charts/vector/templates/_pod.tpl
Outdated
| @@ -174,6 +174,13 @@ tolerations: | |||
| {{- end }} | |||
| {{- with .Values.topologySpreadConstraints }} | |||
| topologySpreadConstraints: | |||
| {{- range $_, $entry := . }} | |||
| {{- if not (dig "labelSelectors" "matchLabels" false $entry) }} | |||
| {{- $ls := "labelSelectors:\n matchLabels: {}" | fromYaml }} | |||
There was a problem hiding this comment.
Not very familiar with this, but the \n seems a bit hacky. I wonder if we can do this more cleanly with a dict.
There was a problem hiding this comment.
I agree, it's kind of gross. I just updated this to use the dict function to create the nested dictionary keys.
|
I'm afraid I don't know enough about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone defines one or more entries in the
topologySpreadConstraintslist and does not define thelabelSelectors.matchLabelskeys then default values will be added. Most people are likely going to want the default selectorLabels so the spread constraints match what they are deploying with this chart.The alternative to this is to run the configuration in this key through the
tplfunction to allow users the ability to call named templates. Similar to howextraObjectsis handled.