Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for retrieval from LDAPresult messages #6

Closed
vanrein opened this issue Apr 14, 2017 · 2 comments
Closed

Add support for retrieval from LDAPresult messages #6

vanrein opened this issue Apr 14, 2017 · 2 comments

Comments

@vanrein
Copy link
Owner

vanrein commented Apr 14, 2017

The simplest result messages contain a result code and/or a string. Optionally, there could be more.

It would be ideal if these could be retrieved from a response message in a generic manner. Especially when passing requests to a server, it is useful to be able to learn easily what it has said.

Similarly, the ability to build such responses through generic support is welcome, because many commands do not require additional data anyway.

@vanrein
Copy link
Owner Author

vanrein commented Apr 14, 2017

One way of doing this is by side-channeling responses to lillyget_response() and lillyput_response(). This would simplify both processing responses and generating them, just as planned above. Moreover, it would integrate nicely with the API above.

The question that remains is when to invoke lillyget_operation() with a more-than-average result. This may be the decision of the configuration, and could possibly be made specifically for an operation code. Whether lillyput_operation() or lillyput_response() is used is a much easier choice; the application simply does what it likes.

We should put some thought into the ordering of the API calls, for sure, but it does seem to make sense to add response handling with a possibly different treatment.

@vanrein
Copy link
Owner Author

vanrein commented Apr 19, 2017

Done in 0f01cdd

@vanrein vanrein closed this as completed Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant