Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split LillyDAP into instance and class #5

Closed
vanrein opened this issue Apr 14, 2017 · 2 comments
Closed

Split LillyDAP into instance and class #5

vanrein opened this issue Apr 14, 2017 · 2 comments

Comments

@vanrein
Copy link
Owner

vanrein commented Apr 14, 2017

The current LillyDAP structure represents two things that ought to be split:

  • structural class aspects, such as the API functions
  • instance data aspects, such as the file handles

We should really split that, and make the instance data aspects reference the structural class aspects.

@vanrein vanrein added this to the version-1.0-alpha1 milestone Apr 14, 2017
@vanrein
Copy link
Owner Author

vanrein commented Apr 19, 2017

The work to map previous code to the new data model is fairly simple:

  • most calls use the data type LDAP or struct LillyConnection
  • allocation is usually for the type LDAP or struct LillyConnection
  • one (or more) static variable can be setup as LillyDAP or struct LillyStructural
    • it is therefore reset to 0 bytes
    • it should reference the opregistry, if any
    • it should setup the function stack in lillyget_xxx() and lillyput_xxx variables
    • it is linked from the def variable of any LDAP instance

@vanrein
Copy link
Owner Author

vanrein commented Apr 19, 2017

Implemented in 7ac7213

@vanrein vanrein closed this as completed Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant