Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: opentelemetry_sdk related dependency issue #3124

Closed
jamesx-improving opened this issue Feb 10, 2025 · 1 comment
Closed

Rust: opentelemetry_sdk related dependency issue #3124

jamesx-improving opened this issue Feb 10, 2025 · 1 comment
Assignees
Labels
bug Something isn't working dependency Dependency management Rust core redis-rs/glide-core matter

Comments

@jamesx-improving
Copy link
Collaborator

Compiling tokio-rustls v0.25.0
error[E0432]: unresolved import `opentelemetry_sdk::trace::TracerProvider`
 --> /home/runner/work/valkey-glide/valkey-glide/glide-core/telemetry/src/open_telemetry.rs:6:5
  |
6 | use opentelemetry_sdk::trace::TracerProvider;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `TracerProvider` in `trace`
  |
help: a similar name exists in the module
  |
6 | use opentelemetry_sdk::trace::SdkTracerProvider;
  |                               ~~~~~~~~~~~~~~~~~
help: consider importing this trait instead
  |
6 | use opentelemetry::trace::TracerProvider;
  |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error[E0433]: failed to resolve: could not find `export` in `opentelemetry_sdk`
 --> /home/runner/work/valkey-glide/valkey-glide/glide-core/telemetry/src/open_telemetry_exporter_file.rs:5:24
  |
5 | use opentelemetry_sdk::export::{self, trace::ExportResult};
  |                        ^^^^^^ could not find `export` in `opentelemetry_sdk`

error[E0432]: unresolved import `opentelemetry_sdk::export`
 --> /home/runner/work/valkey-glide/valkey-glide/glide-core/telemetry/src/open_telemetry_exporter_file.rs:5:33
  |
5 | use opentelemetry_sdk::export::{self, trace::ExportResult};
  |                                 ^^^^ no `export` in the root

   Compiling file-rotate v0.7.6
error[E0425]: cannot find function `shutdown_tracer_provider` in module `global`
   --> /home/runner/work/valkey-glide/valkey-glide/glide-core/telemetry/src/open_telemetry.rs:320:17
    |
320 |           global::shutdown_tracer_provider();
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `set_tracer_provider`
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/opentelemetry-0.28.0/src/global/trace.rs:427:1
    |
427 | / pub fn set_tracer_provider<P, T, S>(new_provider: P) -> GlobalTracerProvider
428 | | where
429 | |     S: trace::Span + Send + Sync + 'static,
430 | |     T: trace::Tracer<Span = S> + Send + Sync + 'static,
431 | |     P: trace::TracerProvider<Tracer = T> + Send + Sync + 'static,
    | |_________________________________________________________________- similarly named function `set_tracer_provider` defined here

error[E0433]: failed to resolve: could not find `export` in `opentelemetry_sdk`
  --> /home/runner/work/valkey-glide/valkey-glide/glide-core/telemetry/src/open_telemetry_exporter_file.rs:48:25
   |
48 | impl opentelemetry_sdk::export::trace::SpanExporter for SpanExporterFile {
   |                         ^^^^^^ could not find `export` in `opentelemetry_sdk`
   |
help: consider importing this module
   |
1  + use opentelemetry_sdk::trace;
   |
help: if you import `trace`, refer to it directly
   |
48 - impl opentelemetry_sdk::export::trace::SpanExporter for SpanExporterFile {
48 + impl trace::SpanExporter for SpanExporterFile {
   |

Some errors have detailed explanations: E0425, E0432, E0433.
For more information about an error, try `rustc --explain E0425`.
error: could not compile `telemetrylib` (lib) due to 5 previous errors
warning: build failed, waiting for other jobs to finish...
Internal Error: Command failed: cargo build --target x86_64-unknown-linux-gnu --features testing_utilities
    at genericNodeError (node:internal/errors:983:15)
    at wrappedFn (node:internal/errors:537:14)
    at checkExecSyncError (node:child_process:[882](https://github.com/valkey-io/valkey-glide/actions/runs/13247510969/job/36978882474#step:4:911):11)
    at Object.execSync (node:child_process:954:15)
    at BuildCommand.<anonymous> (/home/runner/work/valkey-glide/valkey-glide/node/rust-client/node_modules/@napi-rs/cli/scripts/index.js:11529:30)
    at Generator.next (<anonymous>)
    at /home/runner/work/valkey-glide/valkey-glide/node/rust-client/node_modules/@napi-rs/cli/scripts/index.js:3526:69
    at new Promise (<anonymous>)
    at __awaiter$1 (/home/runner/work/valkey-glide/valkey-glide/node/rust-client/node_modules/@napi-rs/cli/scripts/index.js:3522:10)
    at BuildCommand.execute (/home/runner/work/valkey-glide/valkey-glide/node/rust-client/node_modules/@napi-rs/cli/scripts/index.js:11299:16)
Error: Process completed with exit code 1.
@jamesx-improving jamesx-improving added bug Something isn't working Rust core redis-rs/glide-core matter dependency Dependency management labels Feb 10, 2025
@jamesx-improving jamesx-improving self-assigned this Feb 10, 2025
@jamesx-improving
Copy link
Collaborator Author

fixed with #3123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependency Dependency management Rust core redis-rs/glide-core matter
Projects
None yet
Development

No branches or pull requests

1 participant