You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The first 3 tasks are already implemented in the main PR: #2835
Currently, package.json.temp file is used as a template to create the package.json in the npm/glide package. The goal of this task is to remove this package.json.temp from the code. Then, generate a new package.json.temp on runtime from the package.json file. Replace all env. variables in this file and rename it to package.json for npm install to work in the npm/glide package.
The only problem is that we need to add a local devDependency in this newly generated package.json file in step 2.
Reference for this is in this PR: https://github.com/valkey-io/valkey-glide/pull/2835/files#diff-8f0cdcc11832b77fc7f63e79ca1430866e65d7d5e989d9a6b04a8d7612dbc11eR48
Move package.json creation and npm install to node-create-package-file and build-node-wrapper.
Issues for a follow up PR:
Remove scope variable for index.ts of npm/glide. Removing this requires refactoring in existing workflows, therefore, we will need to handle this separately.
Add symbols to npm/glide's index.ts: "AdvancedBaseClientConfiguration", "ClusterScanOptions", "GlideMultiJson"
Find reason for exporting BaseClientConfiguration. If there is no reason, we can remove this from export.
Additional Tasks
No response
The text was updated successfully, but these errors were encountered:
prateek-kumar-improving
changed the title
Remove the package.json.temp file from npm/glide package.
[Tasks] Exported symbols test for node - Additional tasks.
Feb 3, 2025
Description
This task is related to this PR: #2835
Checklist
The first 3 tasks are already implemented in the main PR: #2835
The only problem is that we need to add a local devDependency in this newly generated package.json file in step 2.
Reference for this is in this PR:
https://github.com/valkey-io/valkey-glide/pull/2835/files#diff-8f0cdcc11832b77fc7f63e79ca1430866e65d7d5e989d9a6b04a8d7612dbc11eR48
Issues for a follow up PR:
Additional Tasks
No response
The text was updated successfully, but these errors were encountered: