From 2634e4b7385465440c2a73ae9bf4914ea06904bf Mon Sep 17 00:00:00 2001 From: Roshan Khatri Date: Wed, 10 Apr 2024 22:03:00 +0000 Subject: [PATCH 1/2] update read me with steps to create new release image Signed-off-by: Roshan Khatri --- README.md | 9 +++++++++ temp.sh | 10 ++++++++++ 2 files changed, 19 insertions(+) create mode 100755 temp.sh diff --git a/README.md b/README.md index f6a043f..fa46f55 100644 --- a/README.md +++ b/README.md @@ -3,3 +3,12 @@ This Project is the Git repo of the [Valkey "Official Image"](https://hub.docker The Project is now maintained by [the Valkey Community](https://github.com/valkey-io/valkey/) and it was forked from https://github.com/docker-library/redis. +## How to build and publish new version Docker Image? +*Pre-requisites: Fork this repo, create a private dockerhup repo and setup the Github secrets to access the private dockerhup repo.* +1. Validate if the metadata for the new version is updated at https://github.com/valkey-io/valkey-hashes/blob/main/README +2. If its a new major version create a new dir. For example `7.2`. +3. Run the `update.sh` script locally, which will update the `versions.json` and also populate the Dockerfiles for the new versions in the repective directories. +4. Validate if the version and the info is populated correctly. +5. See if all the tests pass on your fork and the your private docker up has been updated. +5. Publish a PR with these changes. For example: https://github.com/valkey-io/valkey-container/pull/8 +6. Once the PR is merged, Sit back, relax and enjoy looking at your creation getting publish to the official Docker hub page. \ No newline at end of file diff --git a/temp.sh b/temp.sh new file mode 100755 index 0000000..b14865e --- /dev/null +++ b/temp.sh @@ -0,0 +1,10 @@ +#!/bin/bash + +original_tags='[ + valkey-container:unstable, + valkey-container:unstable-bookworm +]' + +converted_list=$(echo $original_tags | sed 's/valkey-container/valkey\/valkey/g'| sed 's/\[ *//; s/ *\]//; s/ //g') +echo $converted_list + From d92755a514ecf09cc3c6bd8e2100a432e402973b Mon Sep 17 00:00:00 2001 From: Roshan Khatri Date: Tue, 23 Apr 2024 00:25:43 +0000 Subject: [PATCH 2/2] Update README Signed-off-by: Roshan Khatri --- README.md | 20 ++++++++++++-------- temp.sh | 10 ---------- 2 files changed, 12 insertions(+), 18 deletions(-) delete mode 100755 temp.sh diff --git a/README.md b/README.md index fa46f55..7371218 100644 --- a/README.md +++ b/README.md @@ -3,12 +3,16 @@ This Project is the Git repo of the [Valkey "Official Image"](https://hub.docker The Project is now maintained by [the Valkey Community](https://github.com/valkey-io/valkey/) and it was forked from https://github.com/docker-library/redis. +## When to build and publish new Docker Image? +After a new major, minor or patch version of Valkey is released on https://github.com/valkey-io/valkey. + ## How to build and publish new version Docker Image? -*Pre-requisites: Fork this repo, create a private dockerhup repo and setup the Github secrets to access the private dockerhup repo.* -1. Validate if the metadata for the new version is updated at https://github.com/valkey-io/valkey-hashes/blob/main/README -2. If its a new major version create a new dir. For example `7.2`. -3. Run the `update.sh` script locally, which will update the `versions.json` and also populate the Dockerfiles for the new versions in the repective directories. -4. Validate if the version and the info is populated correctly. -5. See if all the tests pass on your fork and the your private docker up has been updated. -5. Publish a PR with these changes. For example: https://github.com/valkey-io/valkey-container/pull/8 -6. Once the PR is merged, Sit back, relax and enjoy looking at your creation getting publish to the official Docker hub page. \ No newline at end of file +*Pre-requisites: [Fork](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo) this repo, create a private dockerhup repo and setup the Github secrets to access the private dockerhup repo.* +1. Validate if the metadata for the new version is updated at https://github.com/valkey-io/valkey-hashes/blob/main/README - If it is not updated, please open an issue here https://github.com/valkey-io/valkey-hashes/issues +2. If a new major or minor version is released, please create a new dir in the `valkey-container` repo. For example [`7.2`](https://github.com/valkey-io/valkey-container/tree/mainline/7.2). +3. Run the `update.sh` script locally, which will update the `versions.json` and also populate the Dockerfiles for the new versions in the respective directories. Running the `update.sh` file, executes the `versions.sh` which updates the `versions.json` file with the required metadata from https://github.com/valkey-io/valkey-hashes/blob/main/README. Once `versions.json` is updated, `apply-templates.sh` is executed which updates Docker files for all the versions directories in the repo (For example, [`7.2`](https://github.com/valkey-io/valkey-container/tree/mainline/7.2)). +4. Validate if the version and the info is populated correctly from the https://github.com/valkey-io/valkey-hashes/blob/main/README file. +5. See if all the tests pass on your fork and the your private docker hub has been updated. +5. Update the `dockerhub-description.md` with the updated tags in your private docker hub and the Docker files links. +6. Publish a PR with these changes. For example: https://github.com/valkey-io/valkey-container/pull/8 +7. Once the PR is merged, Sit back, relax and enjoy looking at your creation getting published to the official Docker hub page. \ No newline at end of file diff --git a/temp.sh b/temp.sh deleted file mode 100755 index b14865e..0000000 --- a/temp.sh +++ /dev/null @@ -1,10 +0,0 @@ -#!/bin/bash - -original_tags='[ - valkey-container:unstable, - valkey-container:unstable-bookworm -]' - -converted_list=$(echo $original_tags | sed 's/valkey-container/valkey\/valkey/g'| sed 's/\[ *//; s/ *\]//; s/ //g') -echo $converted_list -