Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuConfiguration does not respect title from view that implements HasDynamicTitle #20802

Open
simasch opened this issue Jan 4, 2025 · 6 comments

Comments

@simasch
Copy link

simasch commented Jan 4, 2025

MenuConfiguration should use the title from getPageTitle if the view is implementing HasDynamicTitle.

Currently, MenuConfiguration is unusable if the application is translated.

@Legioth
Copy link
Member

Legioth commented Jan 4, 2025

The challenge in the general case is that MenuConfiguration cannot know when getPageTitle() should be run again.

@simasch
Copy link
Author

simasch commented Jan 5, 2025

How do you mean that?
Usually the UI is displayed in the language of the user and if the user changes the language most often a page reload is required, because also the some data must be reloaded.

@Legioth
Copy link
Member

Legioth commented Jan 5, 2025

Most often yes, but the question is whether we can assume that it's close enough to always?

@simasch
Copy link
Author

simasch commented Jan 5, 2025

It would at least make it usable. Currently I can't use it and in Switzerland all applications need I18N so it's also unusable for my clients

@Artur-
Copy link
Member

Artur- commented Jan 5, 2025

Sounds wrong that you would need to implement a dynamic title just to get it translated

@simasch
Copy link
Author

simasch commented Jan 5, 2025

That's true!

But how to translate text in annotations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📥Inbox - needs triage
Development

No branches or pull requests

3 participants