Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-drag-over-target is not removed when the drop is ending in a nested drop target #20607

Closed
enver-haase opened this issue Dec 3, 2024 · 2 comments

Comments

@enver-haase
Copy link
Contributor

Description of the bug

When vaadin/web-components#8476 was fixed, the fix unfortunately broke the case where a drop target is nested in (added to) another drop target.

Expected behavior

The application should work just like it did in 24.5.0 .

Minimal reproducible example

Screenshot 2024-12-03 at 12 07 49
Screenshot 2024-12-03 at 12 09 12

Versions

  • Vaadin / Flow version: Vaadin 24.5.6
@probert94
Copy link

I am facing the same problem in Vaadin 24.4.20. In the version we used before (24.4.14) it was still working.
The class for nested drop targets is only removed when the drop happens on them. So if you drag over 4 nested drop targets and drop it on one of them, 3 still keep the class

@mshabarov mshabarov self-assigned this Dec 20, 2024
@mshabarov mshabarov moved this from 🟢Ready to Go to ⚒️ In progress in Vaadin Flow ongoing work (Vaadin 10+) Dec 20, 2024
@tepi tepi self-assigned this Jan 7, 2025
@mshabarov mshabarov removed their assignment Jan 7, 2025
@tepi
Copy link
Contributor

tepi commented Jan 9, 2025

Investigated the issue and indeed, this is a regression due to fixing vaadin/web-components#8476. The commit is reverted [here](https://github.com/vaadin/flow/pull/20822) and will trickle down to affected versions as well. So I'll close this ticket now and will re-open vaadin/web-components#8476 since it seems we need some other kind of fix for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants