Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up cgmath initializers #100

Open
vE5li opened this issue Sep 29, 2024 · 0 comments
Open

Clean up cgmath initializers #100

vE5li opened this issue Sep 29, 2024 · 0 comments
Assignees
Labels
cleanup Improving the code quality or refine functionality good first issue Good for newcomers help wanted Extra attention is needed

Comments

@vE5li
Copy link
Owner

vE5li commented Sep 29, 2024

There are a lot of places all over the code base where we initialize points and vectors like this

camera_position: Point3::new(0.0, 0.0, 0.0),
view_direction: Vector3::new(1.0, 0.0, 0.0),
look_up_vector: Vector3::new(0.0, -1.0, 0.0),

While perfectly valid, there are functions provided by cgmath such as unit_x/unit_y/unit_z for initializing Vectors and zero for Point3.

This is a very easy task and just requires some manual labor.

@vE5li vE5li added help wanted Extra attention is needed good first issue Good for newcomers cleanup Improving the code quality or refine functionality labels Sep 29, 2024
@vE5li vE5li self-assigned this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Improving the code quality or refine functionality good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant