-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Concern #35
Comments
I'm worried about the same thing. How to resolve this issue? Can you elaborate a bit deeper? |
Really sad to see such a great plugin no longer maintained. I will fork and try to implement the suggested changes later this day and would be happy to have your second sight/feedback. |
Focus is on opauth 1.0 where this plugin would be redundant.
|
Having a quick look at 1.0s documentation raises the question if this will only be compatible with Cake 3 (since the use of namespaces). If so, this issue is big enough to receive some more attention. |
You can use namespaced libs just fine in any cakephp version
|
@ceeram for those we don't know, why this will be redundant? Thanks. |
This plugin uses a redirection (to /opauth-complete) to let you handle authenticated users data and try to identify them against your database. Thus anyone sending a post request with consistent auth response data ( existing 'uid' in database, 'validated' => true ) will login successfully !
A possible solution to this issue would be to call (from OpatuhController) a protected "_callback" function defined in AppController. Another would be to use CakePHP 2.1+ EventSystem to dispatch an 'Opauth.complete' event with auth data as parameter.
The text was updated successfully, but these errors were encountered: