Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI, enhancement] track bazelisk using renovatebot #3078

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[CI, enhancement] track bazelisk using renovatebot #3078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee4f24d
Update bazelisk.sh
icfaust Feb 17, 2025
590c7a6
Update renovate.json
icfaust Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .ci/env/bazelisk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@
#===============================================================================

# Download Bazelisk
VERSION=v1.18.0
export SHA256="ce52caa51ef9e509fb6b7e5ad892e5cf10feb0794b0aed4d2f36adb00a1a2779 bazelisk-linux-amd64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case when the renovate updates the bazelisk version, checksum will remain linked to the previous artifact. This will cause an issues.

It may be worth checking if bazelisk provides checksums for release artifacts, and if so, it might also make sense to consider integrating updates and SHA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the point @homksei . It looks like bazelbuild/bazelisk#418 hasn't been integrated so if we wanted to download them and check an SHA we would have to do it manually...

wget https://github.com/bazelbuild/bazelisk/releases/download/v1.18.0/bazelisk-linux-amd64
wget https://github.com/bazelbuild/bazelisk/releases/download/$VERSION/bazelisk-linux-amd64
echo ${SHA256} | sha256sum --check
# "Install" bazelisk
chmod +x bazelisk-linux-amd64
Expand Down
9 changes: 8 additions & 1 deletion .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@
"matchStrings": ["VERSION=(?<currentValue>v\\d+\\.\\d+\\.\\d+)"],
"depNameTemplate": "editorconfig-checker/editorconfig-checker",
"datasourceTemplate": "github-releases"
}
},
{
"customType": "regex",
"fileMatch": ["^\\.ci\\/env\\/bazelisk\\.sh$"],
"matchStrings": ["VERSION=(?<currentValue>v\\d+\\.\\d+\\.\\d+)"],
"depNameTemplate": "bazelbuild/bazelisk",
"datasourceTemplate": "github-releases"
},
]
}
Loading