Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DAAL examples build failures with C++20 #3072

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Fix DAAL examples build failures with C++20 #3072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83dea4d
Add examples compilation with C++20 on linux
Vika-F Feb 14, 2025
b56e2e0
Fix template constructors definitions incompatible with C++20
Vika-F Feb 14, 2025
f5fd327
Change Alloc::pointer (invalid since C++11) to std::allocator_traits<…
Vika-F Feb 14, 2025
ee5cac2
clang-format
Vika-F Feb 14, 2025
55081cb
Revert the change in cmake
Vika-F Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/daal/include/algorithms/covariance/covariance_distributed.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ class Distributed<step1Local, algorithmFPType, method> : public Online<algorithm
typedef typename super::ResultType ResultType;
typedef typename super::PartialResultType PartialResultType;

Distributed<step1Local, algorithmFPType, method>() : Online<algorithmFPType, method>() {}
Distributed() : Online<algorithmFPType, method>() {}

/**
* Constructs an algorithm for correlation or variance-covariance matrix computation
Expand Down
2 changes: 1 addition & 1 deletion cpp/daal/include/algorithms/linear_regression/linear_regression_training_distributed.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ class Distributed<step1Local, algorithmFPType, method> : public Online<algorithm
typedef typename super::PartialResultType PartialResultType;

/** Default constructor */
Distributed<step1Local, algorithmFPType, method>() {}
Distributed() {}

/**
* Constructs a linear regression training algorithm in the first step of the distributed processing mode
Expand Down
2 changes: 1 addition & 1 deletion cpp/daal/include/algorithms/linear_regression/linear_regression_training_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ template <>
class DAAL_EXPORT DistributedInput<step2Master> : public daal::algorithms::Input, public InputIface
{
public:
DistributedInput<step2Master>();
DistributedInput();
/**
* Gets an input object for linear regression model-based training
* in the second step of the distributed processing mode
Expand Down
2 changes: 1 addition & 1 deletion cpp/daal/include/algorithms/ridge_regression/ridge_regression_training_distributed.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class Distributed<step1Local, algorithmFPType, method> : public Online<algorithm
typedef typename super::PartialResultType PartialResultType;

/** Default constructor */
Distributed<step1Local, algorithmFPType, method>() : Online<algorithmFPType, method>() {}
Distributed() : Online<algorithmFPType, method>() {}

/**
* Constructs a ridge regression training algorithm in the first step of the distributed processing mode by copying input objects and parameters
Expand Down
4 changes: 3 additions & 1 deletion cpp/oneapi/dal/detail/common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,9 @@ static constexpr auto allocate(Alloc& alloc, std::int64_t count) {
}

template <typename Alloc>
static constexpr void deallocate(Alloc& alloc, typename Alloc::pointer ptr, std::int64_t count) {
static constexpr void deallocate(Alloc& alloc,
typename std::allocator_traits<Alloc>::pointer ptr,
std::int64_t count) {
using allocator_traits_t =
typename std::allocator_traits<Alloc>::template rebind_traits<typename Alloc::value_type>;
if (ptr != nullptr) {
Expand Down
Loading