Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025 fix #2963

Merged
merged 17 commits into from
Oct 30, 2024
Merged

2025 fix #2963

merged 17 commits into from
Oct 30, 2024

Conversation

emmwalsh
Copy link
Contributor

Description

There are some broken links in oneDAL that seem to have been deleted so I have removed them from documentation. Can you please review this PR and confirm if these links can be removed? Thanks

@@ -34,7 +34,7 @@ The project offers a comprehensive set of optimized libraries, including the OAP
DAAL CPP SYCL Interfaces
************************

**Deprecation:** The `DAAL CPP SYCL Interfaces <https://github.com/oneapi-src/oneDAL/tree/main/examples/daal/cpp_sycl>`_ in the oneDAL library are deprecated. Starting with the 2024.0 release, oneDAL will not support the DAAL CPP SYCL Interfaces.
**Deprecation:** The `DAAL CPP SYCL Interfaces in the oneDAL library are deprecated. Starting with the 2024.0 release, oneDAL will not support the DAAL CPP SYCL Interfaces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Deprecation:** The `DAAL CPP SYCL Interfaces in the oneDAL library are deprecated. Starting with the 2024.0 release, oneDAL will not support the DAAL CPP SYCL Interfaces.
**Deprecation:** The DAAL CPP SYCL Interfaces in the oneDAL library are deprecated. Starting with the 2024.0 release, oneDAL will not support the DAAL CPP SYCL Interfaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this section can just be removed since they have transitioned from deprecated to removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through entire file - is any functionality listed in this file deprecated still or has it all been removed at this point?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ethanglaser, im not too sure. @maria-Petrova would you be able to confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should just remove section on this one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@napetrov DAAL CPP SYCL Interfaces section or all deprecated interfaces section?

@@ -20,7 +20,6 @@
contain the root `toctree` directive.

.. |spec| replace:: |short_name| specification
.. _spec: https://spec.oneapi.com/versions/latest/elements/oneDAL/source/index.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@emmwalsh emmwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@napetrov @ethanglaser I have made the edits. Can you please review them? Thanks!

Copy link
Contributor Author

@emmwalsh emmwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@napetrov @ethanglaser can you review these changes please? Thanks!

@Alexsandruss Alexsandruss added the docs Issue/PR related to oneDAL docs label Oct 30, 2024
@@ -18,7 +18,7 @@
Deprecation Notice
==================

This page provides information about the deprecations of a specific oneDAL functionality.
This page provides information about the deprecations of a specific Intel(R) oneAPI Data Analytics Library (oneDAL) functionality.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With move to UXL this should be non Intel oneDAL name as this is generic documentation vs Intel specific. Might be worth broader fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @napetrov should I change this to "oneAPI Data Analytics Library (oneDAL)" instead?

removed Intel (R) branding
Copy link
Contributor Author

@emmwalsh emmwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@napetrov I have updated the branding now

@napetrov napetrov merged commit 4202cff into uxlfoundation:main Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issue/PR related to oneDAL docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants