-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2025 fix #2963
2025 fix #2963
Conversation
cant find where the links have been moved
docs/source/deprecation.rst
Outdated
@@ -34,7 +34,7 @@ The project offers a comprehensive set of optimized libraries, including the OAP | |||
DAAL CPP SYCL Interfaces | |||
************************ | |||
|
|||
**Deprecation:** The `DAAL CPP SYCL Interfaces <https://github.com/oneapi-src/oneDAL/tree/main/examples/daal/cpp_sycl>`_ in the oneDAL library are deprecated. Starting with the 2024.0 release, oneDAL will not support the DAAL CPP SYCL Interfaces. | |||
**Deprecation:** The `DAAL CPP SYCL Interfaces in the oneDAL library are deprecated. Starting with the 2024.0 release, oneDAL will not support the DAAL CPP SYCL Interfaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Deprecation:** The `DAAL CPP SYCL Interfaces in the oneDAL library are deprecated. Starting with the 2024.0 release, oneDAL will not support the DAAL CPP SYCL Interfaces. | |
**Deprecation:** The DAAL CPP SYCL Interfaces in the oneDAL library are deprecated. Starting with the 2024.0 release, oneDAL will not support the DAAL CPP SYCL Interfaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this section can just be removed since they have transitioned from deprecated to removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through entire file - is any functionality listed in this file deprecated still or has it all been removed at this point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ethanglaser, im not too sure. @maria-Petrova would you be able to confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should just remove section on this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@napetrov DAAL CPP SYCL Interfaces section or all deprecated interfaces section?
Co-authored-by: ethanglaser <[email protected]>
@@ -20,7 +20,6 @@ | |||
contain the root `toctree` directive. | |||
|
|||
.. |spec| replace:: |short_name| specification | |||
.. _spec: https://spec.oneapi.com/versions/latest/elements/oneDAL/source/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be fixed and not removed -
https://oneapi-spec.uxlfoundation.org/specifications/oneapi/v1.3-rev-1/elements/onedal/source/#
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@napetrov @ethanglaser I have made the edits. Can you please review them? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@napetrov @ethanglaser can you review these changes please? Thanks!
docs/source/deprecation.rst
Outdated
@@ -18,7 +18,7 @@ | |||
Deprecation Notice | |||
================== | |||
|
|||
This page provides information about the deprecations of a specific oneDAL functionality. | |||
This page provides information about the deprecations of a specific Intel(R) oneAPI Data Analytics Library (oneDAL) functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With move to UXL this should be non Intel oneDAL name as this is generic documentation vs Intel specific. Might be worth broader fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @napetrov should I change this to "oneAPI Data Analytics Library (oneDAL)" instead?
removed Intel (R) branding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@napetrov I have updated the branding now
Description
There are some broken links in oneDAL that seem to have been deleted so I have removed them from documentation. Can you please review this PR and confirm if these links can be removed? Thanks