Improve SYCL kernels in CSR table #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/intelci: run |
|
/intelci: run |
Vika-F
requested review from
Alexsandruss,
samir-nasibli and
Alexandr-Solovev
as code owners
Vika-F
requested review from
avolkov-intel
and removed request for
samir-nasibli and
Alexsandruss
|
/intelci: run |
|
|
||
| sycl::event::wait_and_throw({ event_count_lt_min, event_count_gt_max }); | ||
| // count the number of elements which are less than min_vaule and | ||
| // the the number of elements which are greater than max_value using sycl::reduction |
| @@ -418,10 +419,9 @@ bool is_sorted(sycl::queue& queue, | |||
| auto count_descending_reduction = | |||
| sycl::reduction(count_buf, cgh, sycl::ext::oneapi::plus<std::int64_t>()); | |||
|
|
|||
| cgh.parallel_for(sycl::nd_range<1>{ count - 1, 1 }, | |||
| cgh.parallel_for(sycl::range<1>{ dal::detail::integral_cast<std::size_t>(count - 1) }, | |||
There was a problem hiding this comment.
Not sure, that this was necessary
avolkov-intel
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL reduction kernels were improved in
csr_tableclass implementation:nd_range<1>was changed torange<1>. The incorrectly used work group size was removed.nd_item<1>was changed toid