Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded Memo collapses when checkbox is toggled #4274

Open
drewski3420 opened this issue Jan 5, 2025 · 1 comment
Open

Expanded Memo collapses when checkbox is toggled #4274

drewski3420 opened this issue Jan 5, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@drewski3420
Copy link

drewski3420 commented Jan 5, 2025

Describe the bug

In the Web UI, when I check or uncheck an item on a memo that is expanded using "Show more", the memo collapses, so that it has to be expanded again to see the full list. Instead, the memo should stay expanded.

Steps to reproduce

  1. Go to a memo that contains checkboxes and more than 10 lines (so that "Show more" is available)
  2. Click on "Show more" to view the whole memo
  3. Check or uncheck any checkbox item.
  4. The check is applied, then the memo is collapsed

The version of Memos you're using

v0.23.0

Screenshots or additional context

No response

@drewski3420 drewski3420 added the bug Something isn't working label Jan 5, 2025
@drewski3420 drewski3420 changed the title Expanded Memo collapses when checkbox is togggled Expanded Memo collapses when checkbox is toggled Jan 5, 2025
@RoccoSmit
Copy link
Contributor

RoccoSmit commented Jan 6, 2025

Previous references to issue #4133, #4110

From memory, I believe this had something to do with the editor read more / read less state value being reset on component re renders so on checkbox click the editor re renders and the state gets set back to read more, or something to that effect. I'd imagine the state needs to get managed up a level where re rendering would not affect it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants