Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced search form field labels cannot be translated #4271

Open
dandelionmood opened this issue Jan 3, 2025 · 2 comments
Open

Advanced search form field labels cannot be translated #4271

dandelionmood opened this issue Jan 3, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@dandelionmood
Copy link
Contributor

Describe the bug

A couple of values from this popup cannot be translated as they are written directly in the code:
image

See web/src/components/MemoDisplaySettingMenu.tsx for reference.

Steps to reproduce

  1. Change language to anything but English
  2. Click on the filter icon next to the search text field in the right hand column
  3. Strings are still in English

The version of Memos you're using

v0.23.0

Screenshots or additional context

N/A

@dandelionmood dandelionmood added the bug Something isn't working label Jan 3, 2025
@dandelionmood
Copy link
Contributor Author

I think I can take care of this one, looks easy.

I would assume that I need to use other translated strings as a reference point, then add new translation entries in (at least) the locale/en.json file?

@RoccoSmit
Copy link
Contributor

Yes, have a look in the react code for references to how useTranslate is used.
locale/en.json is the base so new value need to be added there or existing values can be used if it makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants