Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate internal_container_registry env var scope #3878

Open
rocketeerbkw opened this issue Feb 6, 2025 · 1 comment
Open

Deprecate internal_container_registry env var scope #3878

rocketeerbkw opened this issue Feb 6, 2025 · 1 comment

Comments

@rocketeerbkw
Copy link
Member

With the removal of harbor from Lagoon core, env vars with scope internal_container_registry are no longer used. We should deprecated it, possibly remove it.

At a minimum, we can remove all usage in resolvers and delete data in the api-db. Maybe we have to keep the enum value but we can return an error if we want to be super BC careful (not sure there's a valid reason though).

@shreddedbacon
Copy link
Member

We can follow the same deprecation process we've done for other things. Announce the deprecation, then in a subsequent release remove it entirely.

Since the harbor core support is already gone, we can do this a bit differently but still follow the same thing.

  • announce deprecation
  • keep the enum
  • remove data as required
  • no-op api interactions

In a subsequent release

  • remove the enum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants