fix(create_table): avoid creating unintended foreign keys #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foreign keys should only be created for has-one and belongs-to relations iff: - None of the referencing columns is a primary keys - The table is an m2m 'junction' table an all referencing columns are primary keys
The m2m edge case is covered by TestDatabaseInspector_Inspect
|
LGTM @bevzzz Can you help resolve the conflict caused by a previous merge? |
Done 👌 Btw, do we squash PR commits or not? |
I personally prefer squash commits, so that the master branch focuses only on the final result rather than the intermediate process. However, this is not currently mandatory. |
I'm going to take that as a green light and merge this, @j2gg0s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foreign keys should be created for has-one and belongs-to relations iff:
See more details in this comment.
Closes #1115