Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys in ethr-did documents should list controller instead of owner #29

Open
mirceanis opened this issue Oct 8, 2019 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@mirceanis
Copy link
Collaborator

mirceanis commented Oct 8, 2019

The DID spec mentions a controller property for DID public key entries.
Our resolver uses owner to describe a similar concept.

There is a slight difference in semantics. When the owner of an identity is changed in the ERC1056 registry, this should be reflected in the DID document entry in the controller field of the root key.

More specifically, if keyA calls changeOwner, listing keyB as the new owner, the DID document entry now looks like this:

{
    id: 'did:ethr:0xkeyA#owner',
    type: 'Secp256k1VerificationKey2018',
    owner: 'did:ethr:0xkeyA',
    ethereumAddress: '0xkeyB'
}

A correction should be made to the did-resolver such that the public key entry should appear like so:

{
    id: 'did:ethr:0xkeyA#owner',
    type: 'Secp256k1VerificationKey2018',
    controller: 'did:ethr:0xkeyB',
    ethereumAddress: '0xkeyB'
}

This mirrors [ #168401735 ] in PT

@mirceanis mirceanis added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Oct 8, 2019
@ugoamanoh ugoamanoh self-assigned this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants