getKeys does not return normalised keys

[43081j]

Environment

N/A (all)

Reproduction

// with the fs driver

// writes `foo/bar`
await storage.setItem("foo:bar", "content");

// returns `foo/bar`
await storage.getKeys();

Describe the bug

When we setItem, we normalise keys by replacing / with :.

This means, in the FS adapters especially, both setItem("foo/bar", v) or setItem("foo:bar", v) will write to the same file.

however, when we later call getKeys(), we don't translate those keys on the way out.

this means we will receive / separated keys (e.g. foo/bar in the previous example).

we probably only want to deal with / separated keys as input, but always expose keys from our side as : separated. that would mean getKeys of each driver needs to replaceAll("/", ":") basically.

Additional context

No response

Logs

No response

[pi0]

Thanks for the detailed issue (strange we haven't caught it before!).

• Tests should have ensure getKeys() returns with : notion
• fs driver should normalize returned keys
• Core should normalize keys (in case of similar driver issues (lets do it if we see more drivers have this issue)

[43081j]

@pi0 i had another look at this and think i was talking nonsense, somehow

it seems Storage does normalise in getKeys (across all drivers), and individual storage drivers don't

i was probably running getKeys on the driver itself when i saw this behaviour, thats the only explanation i can think of

so we can close this if you like, the current tests already cover it from Storage point of view

[pi0]

Okay, okay thanks for confirm. let's close it, if you had any chance to evaluate how many "drivers" currently don't normalize (if majority do, we might remove core overheadperhaps not sure if there is benefit..)