Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge cosmos sdk state modules #3526

Open
benluelo opened this issue Jan 16, 2025 · 1 comment
Open

Merge cosmos sdk state modules #3526

benluelo opened this issue Jan 16, 2025 · 1 comment
Labels
A-voyager Area: Our voyager relayer C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@benluelo
Copy link
Contributor

Currently we have two separate modules for reading state from cosmos sdk based chains:

https://github.com/unionlabs/union/tree/5f9b75ea6e035937a082097a33370783d7447ada/voyager/modules/state/cosmos-sdk
https://github.com/unionlabs/union/tree/5f9b75ea6e035937a082097a33370783d7447ada/voyager/modules/state/cosmos-sdk-union

These should be merged into one, switching the querying logic based on

union/lib/voyager-message/src/module.rs

Line 29 in 5f9b75e

pub ibc_spec_id: IbcSpecId,

@benluelo benluelo added C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-voyager Area: Our voyager relayer labels Jan 16, 2025
@alituzun

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-voyager Area: Our voyager relayer C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alituzun @benluelo